make PROXY_ROLE_ASSIGNMENT_DRIVER configurable#196
Open
maybenotconnor wants to merge 1 commit intoopencloud-eu:mainfrom
Open
make PROXY_ROLE_ASSIGNMENT_DRIVER configurable#196maybenotconnor wants to merge 1 commit intoopencloud-eu:mainfrom
maybenotconnor wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
Allow PROXY_ROLE_ASSIGNMENT_DRIVER and GRAPH_ASSIGN_DEFAULT_USER_ROLE to be set via environment variables in .env file. - PROXY_ROLE_ASSIGNMENT_DRIVER defaults to oidc - GRAPH_ASSIGN_DEFAULT_USER_ROLE defaults to false When using PROXY_ROLE_ASSIGNMENT_DRIVER=default, set GRAPH_ASSIGN_DEFAULT_USER_ROLE=true to assign the 'user' role to new users.
maybenotconnor
force-pushed
the
feat/configurable-proxy-role-assignment-driver
branch
from
28d9588 to
2512969
Compare
Contributor
|
I agree that you could have the wish to make this configurable. The issue that i see is that this change is only affecting the external idp config. That is hard to communicate in the docs and creates a pitfall, where people will see some unexpected behavior. Could you also imagine to use the custom override feature of that compose project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow PROXY_ROLE_ASSIGNMENT_DRIVER to be set via environment variable in .env file, with oidc remaining as the default value.
I was frustrated that this was hard coded since my OIDC doesn't offer the complete roles scope, so I made it configurable to allow the default auto-assign.